🤖 fix: clarify mandatory PR readiness criteria#9
Merged
Conversation
Member
Author
|
@codex review Please review this docs-only update to PR readiness requirements. |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies PR workflow language so readiness requirements are unambiguous and mandatory for agents.
Background
The previous guidance allowed interpretation gaps around what "ready" means and when it is valid to stop iterating.
Implementation
AGENTS.md..mux/skills/pull-requests/SKILL.mdto require waiting for required checks before completion.Validation
git diff --checkmake verify-vendormake testmake build📋 Implementation Plan
Plan: Make PR-ready waiting requirements unambiguous in agent guidance
Context / Why
The goal is to make both
AGENTS.mdand.mux/skills/pull-requests/SKILL.mdexplicitly MUST-level about waiting for PR readiness before declaring work complete. "Ready" must be concretely defined so agents cannot interpret it loosely.Evidence
AGENTS.md(## PR Workflow (Codex), lines 95–107): says "stay in this loop until ready" and lists steps, but does not define "ready" or use explicit "MUST NOT finish early" language..mux/skills/pull-requests/SKILL.md:## CI & Validation(line 34) uses permissive wording: "you may usewait_pr_checks".### Required Loop Discipline(lines 83–91) says "stay in a review loop until completion" but does not define completion as Codex approval + required CI checks passing.These are sufficient to justify tightening wording and adding explicit completion gates.
Implementation details
Edit
AGENTS.md## PR Workflow (Codex)to define readiness with hard requirements.Edit
AGENTS.mdloop text to be imperative and unambiguous../scripts/wait_pr_ready.sh <pr_number>as the default blocking command when done coding.Edit
.mux/skills/pull-requests/SKILL.mdin## CI & Validationto distinguish optional vs required waits clearly.Edit
.mux/skills/pull-requests/SKILL.md### Required Loop Disciplineto define completion and forbid early stop.Keep the existing narrow early-stop exception, but scope it as an exception to the MUST rule.
Validation approach
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.12